Skip to content

[RFC] dbwrapper: Set global leveldb mmap limit #32447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

laanwj
Copy link
Member

@laanwj laanwj commented May 8, 2025

Set the default leveldb mmap limit to 4096 files from dbwrapper, before creating the first leveldb context.

The motivation here is to remove the need for a custom leveldb patch, see google/leveldb#1265.

After looking into this i'm not as sure whether this is what we want to do:

@DrahtBot
Copy link
Contributor

DrahtBot commented May 8, 2025

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32447.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

Set the default leveldb mmap limit to 4096 from dbwrapper, before
creating the first leveldb context.

The motivation here is to remove the need for a leveldb patch, see
google/leveldb#1265.
@laanwj
Copy link
Member Author

laanwj commented May 8, 2025

Yeah no even "when to call this initialization" isn't clear, this breaks the tests as-is.

@laanwj laanwj closed this May 8, 2025
@laanwj
Copy link
Member Author

laanwj commented May 8, 2025

See bitcoin-core/leveldb-subtree#52 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants