Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SPV-1545): migrate merkle roots endpoint to v2 #941

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jakubmkowalski
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@jakubmkowalski jakubmkowalski self-assigned this Feb 28, 2025
@jakubmkowalski jakubmkowalski requested a review from a team as a code owner February 28, 2025 09:39
Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 162 lines in your changes missing coverage. Please review.

Project coverage is 35.17%. Comparing base (f0f28b3) to head (8ed0069).

Files with missing lines Patch % Lines
api/gen.models.go 0.00% 118 Missing ⚠️
api/gen.api.go 0.00% 28 Missing ⚠️
actions/v2/merkleroots/merkleroots.go 0.00% 8 Missing ⚠️
actions/v2/merkleroots/server.go 0.00% 7 Missing ⚠️
actions/v2/api.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #941      +/-   ##
==========================================
- Coverage   35.45%   35.17%   -0.29%     
==========================================
  Files         425      427       +2     
  Lines       20060    20222     +162     
==========================================
  Hits         7113     7113              
- Misses      12355    12517     +162     
  Partials      592      592              
Flag Coverage Δ
unittests 35.17% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/v2/api.go 0.00% <0.00%> (ø)
actions/v2/merkleroots/server.go 0.00% <0.00%> (ø)
actions/v2/merkleroots/merkleroots.go 0.00% <0.00%> (ø)
api/gen.api.go 0.00% <0.00%> (ø)
api/gen.models.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0f28b3...8ed0069. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants