Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(SPV-1549): refactor txfixture into testability. #940

Merged
merged 4 commits into from
Feb 28, 2025

Conversation

dorzepowski
Copy link
Collaborator

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

@dorzepowski dorzepowski requested a review from a team as a code owner February 28, 2025 07:49
Copy link

github-actions bot commented Feb 28, 2025

Manual Tests

💚 Manual testing by @wregulski resulted in success.

…re-into-testability

# Conflicts:
#	engine/tester/fixtures/txtestability/fixture_tx.go
#	engine/tester/fixtures/users_fixtures.go
#	engine/v2/transaction/outlines/testabilities/assert_outline_output.go
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 32.89474% with 51 lines in your changes missing coverage. Please review.

Project coverage is 35.45%. Comparing base (1c04eb0) to head (df0be9e).

Files with missing lines Patch % Lines
...egrationtests/testabilities/fixture_user_actors.go 0.00% 14 Missing ⚠️
engine/testabilities/fixture_engine.go 0.00% 12 Missing ⚠️
engine/tester/fixtures/txtestability/fixture_tx.go 80.64% 6 Missing ⚠️
engine/testabilities/fixture_faucet.go 0.00% 4 Missing ⚠️
...ster/fixtures/txtestability/ability_transaction.go 0.00% 3 Missing ⚠️
...tlines/testabilities/assert_outline_transaction.go 0.00% 3 Missing ⚠️
...ernal/sql/testabilities/fixture_inputs_selector.go 0.00% 3 Missing ⚠️
...ons/testabilities/fixture_spvwallet_application.go 0.00% 2 Missing ⚠️
.../integrationtests/testabilities/ability_actions.go 0.00% 1 Missing ⚠️
...ternal/testabilities/assert_transaction_details.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #940      +/-   ##
==========================================
- Coverage   35.63%   35.45%   -0.18%     
==========================================
  Files         424      425       +1     
  Lines       20035    20060      +25     
==========================================
- Hits         7139     7113      -26     
- Misses      12299    12355      +56     
+ Partials      597      592       -5     
Flag Coverage Δ
unittests 35.45% <32.89%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../integrationtests/testabilities/ability_actions.go 0.00% <0.00%> (ø)
...ternal/testabilities/assert_transaction_details.go 0.00% <0.00%> (ø)
engine/tester/fixtures/unlocking_resolver.go 0.00% <0.00%> (-61.91%) ⬇️
...on/outlines/testabilities/assert_outline_output.go 0.00% <0.00%> (ø)
...ons/testabilities/fixture_spvwallet_application.go 0.00% <0.00%> (ø)
...ster/fixtures/txtestability/ability_transaction.go 0.00% <0.00%> (ø)
...tlines/testabilities/assert_outline_transaction.go 0.00% <0.00%> (ø)
...ernal/sql/testabilities/fixture_inputs_selector.go 0.00% <0.00%> (ø)
engine/testabilities/fixture_faucet.go 0.00% <0.00%> (ø)
engine/tester/fixtures/txtestability/fixture_tx.go 78.44% <80.64%> (ø)
... and 2 more

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c04eb0...df0be9e. Read the comment docs.

@wregulski wregulski added the tested PR was tested by a team member label Feb 28, 2025
@dorzepowski dorzepowski merged commit f0f28b3 into main Feb 28, 2025
13 checks passed
@dorzepowski dorzepowski deleted the test/refactor-txfixture-into-testability branch February 28, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tested PR was tested by a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants