Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

poc: errorx #920

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

poc: errorx #920

wants to merge 8 commits into from

Conversation

chris-4chain
Copy link
Contributor

Pull Request Checklist

  • 📖 I created my PR using provided : CODE_STANDARDS
  • 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • 🏠 I tested my changes locally.
  • ✅ I have provided tests for my changes.
  • 📝 I have used conventional commits.
  • 📗 I have updated any related documentation.
  • 💾 PR was issued based on the Github or Jira issue.

Copy link

Manual Tests

ℹ️ Remember to ask team members to perform manual tests and to assign tested label after testing.

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 205 lines in your changes missing coverage. Please review.

Project coverage is 35.35%. Comparing base (f7c5f74) to head (23e7e17).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...gine/spverrors/examplecode/clienterr/http_error.go 0.00% 34 Missing ⚠️
engine/spverrors/examplecode/exampleactions/api.go 0.00% 30 Missing ⚠️
engine/spverrors/examplecode/clienterr/builder.go 0.00% 29 Missing ⚠️
api/gen.api.go 0.00% 21 Missing ⚠️
...errors/examplecode/domain/exampledomain/service.go 0.00% 19 Missing ⚠️
...ngine/spverrors/examplecode/mockmiddleware/auth.go 0.00% 19 Missing ⚠️
...ne/spverrors/examplecode/errdef/problem_details.go 0.00% 18 Missing ⚠️
engine/spverrors/examplecode/repos/somerepo.go 0.00% 15 Missing ⚠️
...verrors/examplecode/clienterr/client_errors_def.go 0.00% 9 Missing ⚠️
engine/spverrors/examplecode/utils/utils.go 0.00% 5 Missing ⚠️
... and 2 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #920      +/-   ##
==========================================
- Coverage   35.72%   35.35%   -0.37%     
==========================================
  Files         419      428       +9     
  Lines       19839    20043     +204     
==========================================
  Hits         7087     7087              
- Misses      12161    12365     +204     
  Partials      591      591              
Flag Coverage Δ
unittests 35.35% <0.00%> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
api/gen.models.go 0.00% <ø> (ø)
actions/v2/api.go 0.00% <0.00%> (ø)
engine/spverrors/examplecode/utils/utils.go 0.00% <0.00%> (ø)
logging/error_marshal.go 0.00% <0.00%> (ø)
...verrors/examplecode/clienterr/client_errors_def.go 0.00% <0.00%> (ø)
engine/spverrors/examplecode/repos/somerepo.go 0.00% <0.00%> (ø)
...ne/spverrors/examplecode/errdef/problem_details.go 0.00% <0.00%> (ø)
...errors/examplecode/domain/exampledomain/service.go 0.00% <0.00%> (ø)
...ngine/spverrors/examplecode/mockmiddleware/auth.go 0.00% <0.00%> (ø)
api/gen.api.go 0.00% <0.00%> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0fe0a...23e7e17. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants