Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(ARCO-332): ZMQ coverage review #782

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

test(ARCO-332): ZMQ coverage review #782

wants to merge 19 commits into from

Conversation

domingotaal
Copy link
Collaborator

@domingotaal domingotaal commented Feb 18, 2025 •
edited
Loading

Increase coverage of ZMQ .

  • Added tests for the ZMQ Handler
  • Added tests for ZMQ socket
  • Lint cleanup

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.md with my changes

@domingotaal domingotaal changed the title ZMQ_coverage_review test(ARCO-332): ZMQ coverage review Feb 19, 2025
@domingotaal domingotaal marked this pull request as draft February 20, 2025 09:56
@domingotaal domingotaal marked this pull request as ready for review February 20, 2025 17:18
@domingotaal domingotaal marked this pull request as draft February 25, 2025 09:52
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
28.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@domingotaal domingotaal marked this pull request as ready for review February 25, 2025 14:47
boecklim
boecklim reviewed Feb 28, 2025
View reviewed changes
internal/cache/in_memory.go
return true
}
s.data.Delete(item)
s.data.Delete(item)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is a duplicate and can be removed

boecklim
boecklim reviewed Feb 28, 2025
View reviewed changes
internal/metamorph/zmq_test.go
@@ -148,3 +193,87 @@ func TestZMQDoubleSpend(t *testing.T) {

assert.Equal(t, numberOfMsgs, sCounter)
}

func TestNewZMQHandler(t *testing.T) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this test should be moved to zmq_handler_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boecklim boecklim boecklim left review comments

@shotasilagadzetaal shotasilagadzetaal Awaiting requested review from shotasilagadzetaal

At least 1 approving review is required to merge this pull request.

Assignees

@boecklim boecklim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domingotaal @boecklim