Add bitcoin address model and address input formatting#500
Open
johnny9 wants to merge 2 commits intobitcoin-core:qt6from
Open
Add bitcoin address model and address input formatting#500johnny9 wants to merge 2 commits intobitcoin-core:qt6from
johnny9 wants to merge 2 commits intobitcoin-core:qt6from
Conversation
Add the BitcoinAddress C++ model class that provides: - Address formatting (space-separated groups of 4 characters) - Ellipsis truncation for display - Cursor-aware setAddress() for live editing in text fields - Base58 character filtering and 62-char cap Add two new QML input components: - BitcoinAddressInputField: address input with inline validation error display using alert-filled icon - BitcoinAmountInputField: amount input with unit label, BTC/sat flip toggle, regex validation, and inline error display Register BitcoinAddress as a creatable QML type in bitcoin.cpp and add the new QML components to bitcoin_qml.qrc.
Switch Send recipient address handling from raw QString to BitcoinAddress so address formatting/cursor can be managed. This allows the address input to be spaced every 4 characters so it is easier to read. - Change SendRecipient.address Q_PROPERTY to BitcoinAddress* - Instantiate BitcoinAddress in SendRecipient and validate against address()->address() - Use BitcoinAddressInputField in Send.qml instead of inline address input - Update SendRecipientsListModel and WalletQmlModel call sites for recipient->address()->address() - Update WalletQmlModelTransaction to pull address from BitcoinAddress - Extend LabeledTextInput with cursor/focus/editingFinished plumbing needed by BitcoinAddressInputField
johnny9
force-pushed
the
add-bitcoin-address-model
branch
from
2f910f5 to
0e2555b
Compare
Collaborator
Author
Contributor
Isn't this is already the case on main/master? |
Collaborator
Author
This is for address inputs, specifically for Send. On master only the label on the Receive page had this spacing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces BitcoinAddress model and new BitcoinAddressInputField qml component backed by the model. This formats the address input to have a space between every 4 characters so that the address is easier to read.
Screencast.from.2026-02-15.23-15-26.mp4