Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modkit.Summary, deprecated modkit.Pileup's bedgraph option #334

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

hexylena
Copy link
Contributor

@hexylena hexylena commented Mar 27, 2025

Checklist

  • Pull request details were added to CHANGELOG.md.
  • Documentation was updated (if required).
  • parameter_meta was added/updated (if required).
  • Submodule branches are on develop or a tagged commit.
  • split by strand + methylation call into separate files

I was running the subsequent steps to @rhpvorderman's https://github.com/biowdl/long-read-variant-calling and encountered two steps, one that needed the bed, and one that needed the bedgraph. While looking into how I could get both outputs without running modkit pileup twce, I encountered the following issue

nanoporetech/modkit#210 (comment) and then subsequently nanoporetech/modkit#158 (comment)

This also adds support for modkit summary while I was at it.

@rhpvorderman
Copy link
Contributor

rhpvorderman commented Mar 28, 2025

Looks good. Can you check the linting? It notes that the paramater_meta now contains an input that is no longer present.

EDIT: Did it myself to get this merged.

@rhpvorderman rhpvorderman marked this pull request as ready for review March 28, 2025 14:25
@hexylena
Copy link
Contributor Author

hexylena commented Mar 31, 2025

I think this should work, but I haven't tested this locally yet, maybe we should write per-task tests at some point? I'll test it soon, maybe tomorrow, and if it's successful, then I'll give an indication.

@hexylena
Copy link
Contributor Author

$ wc -l ...
   860750 analysis/90_hg38.pseudoepic.bedgraph
   430879 analysis/90_hg38.pseudoepic.bedgraph_C_+.bedGraph
   429871 analysis/90_hg38.pseudoepic.bedgraph_C_-.bedGraph

ja dat werkt prima

@hexylena hexylena changed the title Deprecated modkit.Pileup's bedgraph option, produce it by default modkit.Summary, deprecated modkit.Pileup's bedgraph option Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants