Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a samtools quickcheck task #332

Merged
merged 4 commits into from
Mar 28, 2025
Merged

Add a samtools quickcheck task #332

merged 4 commits into from
Mar 28, 2025

Conversation

hexylena
Copy link
Contributor

This is designed to enable us to more quickly catch problematic BAMs, and fail earlier in the pipeline than after we've wasted some significant compute time.

Checklist

  • Pull request details were added to CHANGELOG.md.
  • Documentation was updated (if required).
  • parameter_meta was added/updated (if required).
  • Submodule branches are on develop or a tagged commit.

This is designed to enable us to more quickly catch problematic BAMs,
and fail earlier in the pipeline than after we've wasted some
significant compute time.
@rhpvorderman
Copy link
Contributor

A rapid check for truncation is indeed quite a good thing. This happens with some regularity with files supplied by colleagues.

Copy link
Contributor

@rhpvorderman rhpvorderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inputs can be removed in my opinion, but it looks very good.

@hexylena hexylena force-pushed the samtools-quickcheck branch from 846cab2 to 47efde7 Compare March 26, 2025 11:29
@rhpvorderman rhpvorderman merged commit 5838559 into develop Mar 28, 2025
1 check passed
@rhpvorderman rhpvorderman deleted the samtools-quickcheck branch March 28, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants