Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] File Widget: Fix recent urls save/restore #6259

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

ales-erjavec
Copy link
Contributor

@ales-erjavec ales-erjavec commented Dec 15, 2022

Issue

Fixes: gh-6250

Description of changes

Fix used combobox so it inserts new items in the model on focus out.

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #6259 (663ceae) into master (e75f21c) will increase coverage by 0.01%.
The diff coverage is 95.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6259      +/-   ##
==========================================
+ Coverage   86.70%   86.71%   +0.01%     
==========================================
  Files         316      316              
  Lines       68120    68191      +71     
==========================================
+ Hits        59064    59134      +70     
- Misses       9056     9057       +1     

@ales-erjavec ales-erjavec force-pushed the fixes/file-url-combo-save branch 2 times, most recently from 26bb8a4 to 9eeff42 Compare December 16, 2022 13:41
@ales-erjavec ales-erjavec marked this pull request as ready for review December 16, 2022 13:49
@ales-erjavec ales-erjavec force-pushed the fixes/file-url-combo-save branch from 9eeff42 to 787398a Compare December 20, 2022 12:09
@ales-erjavec ales-erjavec force-pushed the fixes/file-url-combo-save branch from 787398a to 663ceae Compare December 20, 2022 12:37
@PrimozGodec PrimozGodec merged commit da5fd99 into biolab:master Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File widget: URL is lost when saving and reopening OWS file
2 participants