Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] HeatMap: Color gradient center value edit #5647

Merged

Conversation

ales-erjavec
Copy link
Contributor

Issue

Fixes gh-5640

Description of changes

Replace use of plain line edit with a DoubleSpinBox

Includes
  • Code changes
  • Tests
  • Documentation

@ales-erjavec ales-erjavec force-pushed the color-gradient-selection-center-spin branch from 8d2f5ee to 9be842a Compare October 13, 2021 12:17
@ales-erjavec ales-erjavec force-pushed the color-gradient-selection-center-spin branch from 9be842a to adc9fbb Compare October 13, 2021 12:27
@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #5647 (adc9fbb) into master (0a34127) will decrease coverage by 0.00%.
The diff coverage is 90.38%.

@@            Coverage Diff             @@
##           master    #5647      +/-   ##
==========================================
- Coverage   85.97%   85.97%   -0.01%     
==========================================
  Files         313      313              
  Lines       65640    65675      +35     
==========================================
+ Hits        56436    56464      +28     
- Misses       9204     9211       +7     

@robertcv
Copy link
Collaborator

Works for me although I have to use a comma as the delimiter. I am using the Slovenian setting on my computer. Is the use of system language-specific delimiters applied everywhere in Orange? I thought it was English-specific everywhere.

@markotoplak markotoplak merged commit 3634e37 into biolab:master Nov 5, 2021
@markotoplak
Copy link
Member

Thanks for bringing a spinbox with non-fixed decimal precision/rounding to my attention: I did not know Orange has it.

@ales-erjavec ales-erjavec deleted the color-gradient-selection-center-spin branch December 28, 2021 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HeatMap centered value issues
3 participants