Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] ContinuousPalettesModel: Disable 'category' items via flags #4538

Merged
merged 1 commit into from
Mar 16, 2020

Conversation

ales-erjavec
Copy link
Contributor

Issue

In Heatmap tab to the palette selection combo, change selection via up/down arrow keys.

-------------------------- AttributeError Exception ---------------------------
Traceback (most recent call last):
  File "/Users/aleserjavec/Documents/workspace/orange3/Orange/widgets/visualize/owheatmap.py", line 917, in update_color_schema
    self.palette_name = self.color_cb.currentData().name
AttributeError: 'NoneType' object has no attribute 'name'
-------------------------------------------------------------------------------
Description of changes

Disable 'category' items via model flags.

Includes
  • Code changes
  • Tests
  • Documentation

Prevent selection in combo box via keyboard up/down arrow navigation.
@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #4538 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4538      +/-   ##
==========================================
- Coverage   83.37%   83.35%   -0.03%     
==========================================
  Files         279      274       -5     
  Lines       55755    54957     -798     
==========================================
- Hits        46485    45808     -677     
+ Misses       9270     9149     -121     

@janezd janezd merged commit 3918955 into biolab:master Mar 16, 2020
@ales-erjavec ales-erjavec deleted the fixes/palette-combo-box branch August 5, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants