[ENH] tSNE: Output preprocessor #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3407 +/- ##
==========================================
- Coverage 82.33% 82.32% -0.01%
==========================================
Files 360 360
Lines 64045 64075 +30
==========================================
+ Hits 52729 52751 +22
- Misses 11316 11324 +8 |
Orange/projection/manifold.py
Outdated
| tsne_cols = [ContinuousVariable('t-SNE-%d' % (i + 1)) | ||
| for i in range(self.tsne.n_components)] | ||
| n = self.tsne.n_components | ||
| postfixes = ['x', 'y'] if n == 2 else list(range(n)) |
There was a problem hiding this comment.
I don't like list(range(n)). While it would very rarely come up, it would imply that the variables are named t-SNE-0, t-SNE-1, t-SNE-2, ... I guess it is consistent with the current behaviour of Manifold learning, which outputs C0, C1. Honestly, I think t-SNE-x and t-SNE-y should be removed in favour of t-SNE-1, t-SNE-2, and if the axes are to be labelled with x and y, this should be done on the t-SNE widget level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Implements third part of #3342
Description of changes
Includes