chore: remove unused code - #1122
Conversation
…emoval Remove 12 template files from bioconda_utils/templates/ that are no longer loaded by any Python code: - bot_*.html, css/, merge_button.svg, artifacts.md: orphaned when the bot web UI module (bioconda_utils/bot/) was removed in cab3df5 (May 2023). No code references these files anymore. - lint_failure.md, lint_success.md: orphaned when the GitHub comment push feature was removed in 950a913 (May 2019), part of the linter rewrite in 9d23688. No code references these files anymore. The three autobump templates (autobump_bump_version_pr.md, autobump_update_pinning_pr.md, autobump_pr.md) are left in place as they are still loaded by autobump.py.
aliciaaevans
left a comment
aliciaaevans
left a comment
There was a problem hiding this comment.
Thanks, some of this hasn't been needed in years.
I still want to take a look at githubhandler.py tomorrow (ran out of time), but here are my comments so far. I think I found a couple more things that can be removed, unless I'm missing some place they are used.
aliciaaevans
left a comment
aliciaaevans
left a comment
There was a problem hiding this comment.
I think that one for loop in test_utils.py is the only thing concerning to me as it's not clear why it was removed.
Co-authored-by: Alicia A. Evans <108547992+aliciaaevans@users.noreply.github.com>
…onda-utils into remove-dead-code
got made redundant by other removals
aliciaaevans
left a comment
aliciaaevans
left a comment
There was a problem hiding this comment.
Looks good. I think the osx tests timed out, so rerunning.
|
Tick the box to add this pull request to the merge queue (same as
|
|
|
Wonderful! |
3 participants
Remove unused code
I used vulture to build an initial list, then excluded false-positives (auto-discovered code etc) as well as anything imported by external scripts in bioconda-recipes.
Lots of html templates were unused since 2019, these are removed as well