Skip to content

fix: Debug startup resilience #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kemalau merged 3 commits into from
Apr 7, 2026
Merged

fix: Debug startup resilience #3

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f04e216
Fix startup resilience for optional deps and schema state
koen666 Apr 6, 2026
78a5b0e
Add VS Code Power Query symbol settings
koen666 Apr 6, 2026
d023e01
Add @koen666 to CLA signers
koen666 Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .vscode/excel-pq-symbols/excel-pq-symbols.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
[
{
"name": "Excel.CurrentWorkbook",
"documentation": {
"description": "Returns the contents of the current Excel workbook.",
"longDescription": "Returns tables, named ranges, and dynamic arrays. Unlike Excel.Workbook, it does not return sheets.",
"category": "Accessing data"
},
"functionParameters": [],
"completionItemKind": 3,
"isDataSource": true,
"type": "table"
},
{
"name": "Documentation",
"documentation": {
"description": "Contains properties for function documentation metadata",
"category": "Documentation"
},
"functionParameters": [],
"completionItemKind": 9,
"isDataSource": false,
"type": "record",
"fields": {
"Name": { "type": "text" },
"Description": { "type": "text" },
"Parameters": { "type": "record" }
}
}

]
Comment on lines +1 to +31
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This symbols file is committed, but the accompanying VS Code setting currently points to an absolute directory outside a typical clone path, so these symbols won’t be picked up by other developers. Either reference this repo-local directory via a workspace-relative setting, or drop this file from the PR to avoid carrying unused editor artifacts in the repository.

Suggested change
[
{
"name": "Excel.CurrentWorkbook",
"documentation": {
"description": "Returns the contents of the current Excel workbook.",
"longDescription": "Returns tables, named ranges, and dynamic arrays. Unlike Excel.Workbook, it does not return sheets.",
"category": "Accessing data"
},
"functionParameters": [],
"completionItemKind": 3,
"isDataSource": true,
"type": "table"
},
{
"name": "Documentation",
"documentation": {
"description": "Contains properties for function documentation metadata",
"category": "Documentation"
},
"functionParameters": [],
"completionItemKind": 9,
"isDataSource": false,
"type": "record",
"fields": {
"Name": { "type": "text" },
"Description": { "type": "text" },
"Parameters": { "type": "record" }
}
}
]
[]

Copilot uses AI. Check for mistakes.
5 changes: 5 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"powerquery.client.additionalSymbolsDirectories": [
"/Users/heke/Deepgraph/.vscode/excel-pq-symbols"
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting uses an absolute, user-specific path ("/Users/heke/..."), which is not portable and also exposes a local username/path in the repo. Prefer a workspace-relative path (e.g., using ${workspaceFolder}) or remove this VS Code-only configuration from the PR (and/or add .vscode to .gitignore if it should remain local-only).

Suggested change
"/Users/heke/Deepgraph/.vscode/excel-pq-symbols"
"${workspaceFolder}/.vscode/excel-pq-symbols"

Copilot uses AI. Check for mistakes.
]
}
4 changes: 2 additions & 2 deletions agents/domain_summary_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
"""Generate plain-language domain summaries and research opportunities."""
from agents.llm_client import call_llm_json


SYSTEM_PROMPT = """You explain research landscapes to non-specialists.

Expand Down Expand Up @@ -44,6 +42,8 @@

def generate_domain_summary(node: dict, snapshot: dict) -> tuple[dict, int]:
"""Generate a node summary from structured evidence."""
from agents.llm_client import call_llm_json

papers = snapshot.get("papers", [])
paper_lines = []
for idx, paper in enumerate(papers[:12], start=1):
Expand Down
12 changes: 12 additions & 0 deletions db/evidence_graph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,12 @@ def _candidate_block_keys(entity: dict) -> set[str]:

def list_merge_candidates(status: str = "pending", limit: int = 100, entity_type: str | None = None) -> list[dict]:
"""List merge candidates with display metadata."""
table_exists = db.fetchone(
"SELECT name FROM sqlite_master WHERE type='table' AND name='entity_merge_candidates'"
)
if not table_exists:
Comment on lines 382 to +387
Copy link

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The table existence check SQL is duplicated here and again in get_merge_candidate_context(). Consider extracting a small helper (e.g., _merge_candidates_table_exists()) to avoid repeating the sqlite_master query and keep future schema-guard changes consistent.

Suggested change
def list_merge_candidates(status: str = "pending", limit: int = 100, entity_type: str | None = None) -> list[dict]:
"""List merge candidates with display metadata."""
table_exists = db.fetchone(
"SELECT name FROM sqlite_master WHERE type='table' AND name='entity_merge_candidates'"
)
if not table_exists:
def _merge_candidates_table_exists() -> bool:
"""Return whether the merge-candidates table is available."""
return bool(
db.fetchone(
"SELECT name FROM sqlite_master WHERE type='table' AND name='entity_merge_candidates'"
)
)
def list_merge_candidates(status: str = "pending", limit: int = 100, entity_type: str | None = None) -> list[dict]:
"""List merge candidates with display metadata."""
if not _merge_candidates_table_exists():

Copilot uses AI. Check for mistakes.
return []

sql = """
SELECT emc.*,
p.canonical_name AS primary_name, p.entity_type AS primary_type,
Expand Down Expand Up @@ -453,6 +459,12 @@ def _collect_entity_context(entity_id: str, limit: int = 5) -> dict:

def get_merge_candidate_context(candidate_id: int) -> dict | None:
"""Return a merge candidate plus supporting node/paper/relation context."""
table_exists = db.fetchone(
"SELECT name FROM sqlite_master WHERE type='table' AND name='entity_merge_candidates'"
)
if not table_exists:
return None

row = db.fetchone(
"""SELECT emc.*,
p.canonical_name AS primary_name, p.entity_type AS primary_type, p.aliases AS primary_aliases,
Expand Down
Loading