Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ea-icon more child-theme friendly #13

Closed
clwill opened this issue Jul 12, 2019 · 1 comment
Closed

Make ea-icon more child-theme friendly #13

clwill opened this issue Jul 12, 2019 · 1 comment

Comments

@clwill
Copy link

clwill commented Jul 12, 2019

I'm loving using EA-starter on my project, but I was hoping to use it as a parent theme, that way I could keep up with any changes here. There are sufficient hooks for nearly everything that I needed to use to make my child work -- except for one minor spot.

My project uses a bunch of SVG icons, and I love the functionality of ea-icon (in helper-functions). But it's not child theme friendly. A one line change makes it work with child themes though.

Simply swapping in get_theme_file_path does the trick.

$icon_path = get_theme_file_path( '/assets/icons/' . $atts['group'] . '/' . $atts['icon'] . '.svg' );

I have a version with this change ready for a pull request if you'd like.

Thanks, and BTW, thank you very much for this theme, I love it.

@billerickson
Copy link
Owner

I think that's a great idea. I'll patch it right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants