Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another small child-theme-friendly issue #14

Closed
clwill opened this issue Jul 13, 2019 · 0 comments
Closed

Another small child-theme-friendly issue #14

clwill opened this issue Jul 13, 2019 · 0 comments

Comments

@clwill
Copy link

clwill commented Jul 13, 2019

Thanks for #13, Bill.

One more reason I had to edit core theme files when making an EA-starter child was this code in header.php.

echo '<div class="title-area">';
$logo_tag = ( apply_filters( 'ea_h1_site_title', false ) || ( is_front_page() && is_home() ) ) ? 'h1' : 'p';
echo '<' . $logo_tag . ' class="site-title"><a href="' . esc_url( home_url() ) . '" rel="home">' . get_bloginfo( 'name' ) . '</a></' . $logo_tag . '>';
//echo '<p class="site-description">' . get_bloginfo( 'description' ) . '</p>';
echo '</div>';

The commenting out of the site description, to be specific. My site uses that description.

I'd love it if this was done as a filter (ala the ea_h1_site_title right above). That way, I wouldn't have to edit this file to un-comment that out. :)

I think that's the only other thing I had to edit to make the whole theme work with a child theme.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant