ci(canary): install Chrome Beta via apt + note Firefox-Beta cannot be a lane#124
Merged
Merged
Conversation
… a lane npx playwright install chrome-beta downloads the browser and intermittently hangs for the full timeout on GitHub-hosted runners (the flake ci.yml sidesteps with the Playwright container) -- the dispatch validation hung on exactly that step. Install Chrome Beta from Google's apt repo instead; Playwright's chrome-beta channel drives the system binary. Also document why there is no Firefox-Beta lane (Playwright ships its own patched Firefox tracking Stable and cannot drive a branded/beta Firefox).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dispatch validation of the browser canary (added in #121) hung —
npx playwright install chrome-betadownloads the browser and freezes for the whole timeout on GitHub-hosted runners. That's the exact flakeci.ymlcalls out and sidesteps by using the Playwright Docker container. So the canary as shipped didn't actually run; validating it caught that before it ever fired on schedule.Fix: install Chrome Beta from Google's apt repo (the standard, non-hanging path) instead of
playwright install. Playwright'schrome-betachannel (already wired viaCHROMIUM_CHANNEL) drives that system binary.Also folds in the D'-1 decision: a header note documenting that there's no Firefox-Beta lane — Playwright ships its own patched Firefox tracking Stable and can't drive a branded/beta Firefox (no
firefoxchannel), so Firefox stays covered by the pinned e2e.Test plan
schedule+workflow_dispatchonly (non-blocking, never a PR context).workflow_dispatchit onmasterafter merge and confirm it goes green against Chrome Beta. That run is the real proof the install path works.