Skip to content

Robustly bump dependency versions #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

jaketae
Copy link
Member

@jaketae jaketae commented Apr 28, 2022

In light of #74, this PR flexibly bumps project dependency versions by replacing hardcoded == version requirements with >=. This will allow pip to install the latest versions when possible and also resolve the test CI error.

Additionally,

  • The unnecessary tensorflow dependency is removed
  • Dependencies are re-ordered to give priority to torch and transformers

@jaketae jaketae requested a review from wilsonyhlee April 28, 2022 05:35
@jaketae
Copy link
Member Author

jaketae commented Apr 28, 2022

@tianjianjiang, can you help update poetry.lock and pyproject.toml files? I think the test CI currently works off of setup.py, which reads from requirements.txt, but I think it's also a good idea to keep other files consistent if we update requirements.txt. Thank you!

@jaketae jaketae requested a review from tttyuntian April 28, 2022 05:37
Copy link
Member

@wilsonyhlee wilsonyhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@wilsonyhlee wilsonyhlee merged commit 9526562 into main Apr 28, 2022
@wilsonyhlee wilsonyhlee deleted the chore-update-versions branch April 28, 2022 05:39
@tianjianjiang
Copy link
Contributor

@tianjianjiang, can you help update poetry.lock and pyproject.toml files? I think the test CI currently works off of setup.py, which reads from requirements.txt, but I think it's also a good idea to keep other files consistent if we update requirements.txt. Thank you!

@jaketae Roger that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants