Repository navigation
fix: Studio report/infographics/poster/slide buttons vanish after AI toggle - #1902
Merged
Merged
Conversation
… toggle
Toggling AI off then on hid the button row permanently. The nested
single-panel navset_underline around the buttons used the same "Studio"
label as the outer sidebar tab. Shiny's nav_hide/nav_show for the AI
toggle resolves its target via a jQuery .find("div[data-value='Studio']")
that matches all descendants, not just the outer tab-pane, so it swept up
the inner pane too. On hide it strips the "active" class from both; on
show it only restores display on the outer one (via the user's tab
click), never the inner one, so the inner pane stays display:none.
Giving the inner nav_panel a distinct value avoids the data-value
collision. Also fixes the board's content layout_columns to use
height = "100%" per the OmicsBoardUI convention instead of a hardcoded
viewport calc().
Fixes #1898.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
ESCRI11
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
navset_underline/nav_panelused the same label ("Studio") as the outer sidebar tab. The AI toggle'snav_hide()/nav_show()resolves its target tab-pane via a jQuery.find("div[data-value='Studio']"), which matches all descendants sharing thatdata-value, not just the sidebar's own pane. On hide, Shiny strips theactiveclass from both matched panes; on show it only restoresdisplayon the outer one (the user's subsequent click re-activates it via Bootstrap's own tab logic) — the inner pane'sactiveclass is never restored, so it staysdisplay:noneforever.nav_panela distinctvalue = "studio-buttons"so it no longer collides with the outer tab'sdata-value="Studio".layout_columnstoheight = "100%"per this repo'sOmicsBoardUIconvention, instead of a hardcodedcalc(100vh - 76px).Test plan