-
Notifications
You must be signed in to change notification settings - Fork 37
Improvements multiwgcna #1678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: devel
Are you sure you want to change the base?
Improvements multiwgcna #1678
Conversation
|
2 new R packages needed: tidyprompt + DiagrammeRsvg |
|
@ESCRI11 Exactly same crash i get... |
This is the DOT diagram code sometimes has errors. Try regenerating in the hamburger menu. |
|
ok. mox-brca still has problems. Please try mox-geiger.pgx (proteomics + metabolomics). But the diagram still has often problems in the generated code. |
|
Is the diagram problem related to our code or what we retrieve from llm? |
|
OK mox-brca should work with the latest playbase "wgcna-upd2" but the diagram in fact still often fails. It seems to depend on the model. It seems better with grok. or please add groq:openai/gpt-oss-20b in your options. this is like gpt5 but faster. |
|
Maybe we can catch failed diagram and re-send to model until something useful comes up? |
|
I added few manual corrections. It should be much less now. Also Llama is pretty poor for the diagram. Yeah, we could perhaps do a 2nd round like "check and correct this code" (could be cool). Or maybe igraph is easier for them? |
OK. same error. Something in getTopModules. I will look at it. |
|
Ahh so llm is building the diagram code itself? That sounds flaky and unreliable. Maybe get bulletpoint list of nodes + direction of connection and aux function that builds the graph is more reliable, way easier to handle bad llm output for sure |
|
True. But sometimes the LLM gives nice annotation on edges, groups, etc. I think it is now much more reliable. GPT and Grok definitely do better job. I also fixed the getTopModules error in playbase. please check again. |
The diagram is coded up by LLM but llama seems bad at coding. Grok or GPT seems better. |
|
Am testing again the PR. Where the corresponding playbase PR? @ivokwee |
|
The AI diagram errors as per above are still appearing often. I suggest adding a shiny::validate/need message saying (please regenerate diagram) instead of displaying the user with the red error line. |
|
We should detect diagram is not fine and regenerate ourselves (max N times), at that point just notify user diagram could not be generated. |
|
Diagram seems to be generated by LLM directly....that is what happens |
|
Multi-WGCNA still appears for single-omics data (example data). I assume this is not the intended behavior. |
|
https://github.com/bigomics/omicsplayground/blob/dev-multiwgcna/components/board.wgcna/R/wgcna_html_report.R#L212 typo here that will crash app |
added this commit to prevent this from happening 410969e |
|
playbase PR used for testing bigomics/playbase#418; dataset is mox-brca: crash in multiWGCNA: |
|
just committed a push to fix a typo most likely causing an edge-case crash in the future. |
|
I pushed some fixes into R/pgx-wgcna.R in bigomics/playbase#418. There are other errors and needs testing. If we do not take action in refactoring the code the pgx-wgcna.R will soon be not maintainable. |
|
I believe there are changes not committed or something went off. There are multiple missing parameters in functions resulting into "objects" or "parameters" not found from corresponding playbase PR. I pushed some fixes...more needed. |
|
mox-brca dataset: "Preservation WGCNA" is broken. Reproducible by clicking at the compute button. |
|
on a separate note, ai diagram still fails sometimes, we need a mechanism to gracefully fail instead of displaying a random error message to the user (which everytime is different) |














Note: Needs PR bigomics/playbase#420 on playbase.