Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flesh out top level input schema #9

Open
wants to merge 2 commits into
base: lattice-changes
Choose a base branch
from

Conversation

nealkruis
Copy link
Member

This PR fleshes out the top-level input schema:

  • Moves simulation settings related inputs out of product representations
  • Creates a placeholder data group for central systems that are built-up and not packaged into an individual product
  • Moves HeatSourceConfiguration to a separate schema since it is common across central and integrated systems

@nealkruis nealkruis requested a review from spahrenk December 16, 2024 18:04
@nealkruis nealkruis self-assigned this Dec 16, 2024
Comment on lines -37 to -46
HeatingLogicTemplate:
Object Type: "Data Group Template"
Required Data Elements:
metadata:
Required: True
performance:
Required: True
description:
Required: False

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to HeatSourceConfiguration.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very similar to the integrated performance, but isn't a Representation Specification since the products are not sold as a package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing split-system presets require the add'l parameters externalOutletHeight and externalInletHeight. Should we add the following to the CWHS schema?

   external_inlet_height:
      Description: "Fractional tank height of inlet"
      Data Type: "Numeric"
      Constrains: "> 0"   
    external_outlet_height:
      Description: "Fractional tank height of outlet"
      Data Type: "Numeric"
      Constrains: "> 0"   

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Good catch. My only question is if these are a property of the tank or the system. I imagine the tanks are sold with hookups at specific heights.

Comment on lines +25 to +34
number_of_nodes:
Description: "Number of tank nodes used for simulation"
Data Type: "Integer"
Constrains: "> 0"
depresses_temperature: # TODO: Move to HPWHsimInput schema
Description: "Depresses space temperature when activated"
Data Type: Boolean
fixed_volume:
Data Type: "Boolean"
Required: False
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simulation specific parameters (not relevant to product manufacturers).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved to a separate schema that can be referenced as needed. Separate from ASHRAE205 schema since they are specific to water heating.

@spahrenk
Copy link
Contributor

spahrenk commented Dec 18, 2024

Will the CWHS include both single- and multi-pass systems? For multi-pass, we also need the flow rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants