-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flesh out top level input schema #9
base: lattice-changes
Are you sure you want to change the base?
Conversation
HeatingLogicTemplate: | ||
Object Type: "Data Group Template" | ||
Required Data Elements: | ||
metadata: | ||
Required: True | ||
performance: | ||
Required: True | ||
description: | ||
Required: False | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to HeatSourceConfiguration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is very similar to the integrated performance, but isn't a Representation Specification since the products are not sold as a package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The existing split-system presets require the add'l parameters externalOutletHeight
and externalInletHeight
. Should we add the following to the CWHS schema?
external_inlet_height:
Description: "Fractional tank height of inlet"
Data Type: "Numeric"
Constrains: "> 0"
external_outlet_height:
Description: "Fractional tank height of outlet"
Data Type: "Numeric"
Constrains: "> 0"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. Good catch. My only question is if these are a property of the tank or the system. I imagine the tanks are sold with hookups at specific heights.
number_of_nodes: | ||
Description: "Number of tank nodes used for simulation" | ||
Data Type: "Integer" | ||
Constrains: "> 0" | ||
depresses_temperature: # TODO: Move to HPWHsimInput schema | ||
Description: "Depresses space temperature when activated" | ||
Data Type: Boolean | ||
fixed_volume: | ||
Data Type: "Boolean" | ||
Required: False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simulation specific parameters (not relevant to product manufacturers).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to a separate schema that can be referenced as needed. Separate from ASHRAE205 schema since they are specific to water heating.
Will the CWHS include both single- and multi-pass systems? For multi-pass, we also need the flow rate. |
This PR fleshes out the top-level input schema: