Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lattice with 232 #13

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Lattice with 232 #13

wants to merge 16 commits into from

Conversation

spahrenk
Copy link
Contributor

Incorporate revisions; update lattice.

@spahrenk spahrenk requested a review from nealkruis January 22, 2025 20:27
@spahrenk spahrenk self-assigned this Jan 22, 2025
nealkruis
nealkruis requested changes Jan 23, 2025
View reviewed changes
Copy link
Member

@nealkruis nealkruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good with the exception of the grid variable names for air-to-water heat pump performance map. They should be changed as follows:

  1. heat_source_temperature -> condenser_entering_temperature
  2. outlet_temperature -> condenser_leaving_temperature

Sorry I didn't catch this earlier when I made the new RS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nealkruis nealkruis nealkruis requested changes

Assignees

@spahrenk spahrenk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spahrenk @nealkruis @tanaya-mankad