Add check to ensure network is a directed acyclical graph #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands the checks done on the network with `erin check`. This uses Tarjan's strongly connected component algorithm and checks to see if strongly connected components (i.e., cycles) exist in the network. If they do, they are reported.
The subcommands were not returning values passed back out to main. Thus, if a subcommand returned a non-zero exit code, it was not being passed out of main. This change enables the exit codes to be captured from subcommands and passed out as main's exit code.
michael-okeefe
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the check functionality to also detect if there are cycles in the network. Networks in ERIN must be directed acyclical graphs (DAG). In this PR, we also discovered that exit codes were not being bubbled up to main's exit correctly. This PR fixes that as well.
Fixes #36