-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export image #11
Export image #11
Changes from 17 commits
385d43b
2d0cca9
5f5b233
8db411b
b32df33
0412b89
4891e18
898ddf0
e4d1c64
721f755
d3e6f24
41d985d
7fdcade
1becdf7
0202348
dfb51d0
a66ef35
d948352
e4c95ef
0e9221a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like a formatter was automatically applied to this file, causing unrelated diffs. Not sure I like it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What do you want to do about it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Change your editor settings so it doesn't automatically format TOML files (or at least disable the reordering of keywords). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I can't find the setting. I will need your help. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,36 +1,37 @@ | ||
[tool.poetry] | ||
name = "dimes" | ||
authors = ["Big Ladder Software"] | ||
description = "A dimensionally aware scientific plotting package." | ||
keywords = ["template"] | ||
license = "BSD-3" | ||
name = "dimes" | ||
readme = "README.md" | ||
repository = "https://github.com/bigladder/dimes" | ||
version = "0.0.0" # Generated from git on CI | ||
description = "A dimensionally aware scientific plotting package." | ||
authors = ["Big Ladder Software"] | ||
license = "BSD-3" | ||
readme = "README.md" | ||
keywords = ["template"] | ||
repository = "https://github.com/bigladder/dimes" | ||
|
||
[tool.poetry.dependencies] | ||
python = "^3.10" | ||
plotly = "*" | ||
koozie = "^1.3.0" | ||
kaleido = "==0.2.1" # Required by plotly to save figures as images | ||
koozie = "^1.3.0" | ||
plotly = "*" | ||
python = "^3.10" | ||
|
||
[tool.poetry.dev-dependencies] | ||
pytest = "^7.1.3" | ||
pylint = "*" | ||
black = "*" | ||
mypy = "*" | ||
pylint = "*" | ||
pytest = "^7.1.3" | ||
|
||
[build-system] | ||
requires = ["poetry-core>=1.0.0"] | ||
build-backend = "poetry.core.masonry.api" | ||
requires = ["poetry-core>=1.0.0"] | ||
|
||
[tool.black] | ||
line-length = 120 | ||
|
||
[tool.mypy] | ||
check_untyped_defs = true | ||
disallow_incomplete_defs = true | ||
no_implicit_optional = true | ||
check_untyped_defs = true | ||
|
||
[[tool.mypy.overrides]] | ||
module = "dimes.*" | ||
disable_error_code = ["import"] | ||
module = "dimes.*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like these are never set in any calls to this function. Can we remove them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width
andheight
are set in lines 245 and 246. Is that what you mean, or is there something else wrong?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two calls to
finalize_plot
(line 461 and line 471), but neither of them actually pass inwidth
orheight
so they are alwaysNone
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want width and height to be passed into finalize_plot? I was debating whether to pass them into finalize_plot or DimensionalPlot.
If passed into DimensionalPlot, then jpeg and html plots are both adjusted. If only passed into write_plot_image (as well as finalize_plot), then jpeg files are the only files with modified height and width, which makes more sense to me.
We could also pass in width and height into write_html_plot, but I don't think that is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review latest changes