Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain performance curves and add 80-gallon LG model #220

Merged
merged 16 commits into from
Dec 11, 2024

Conversation

spahrenk
Copy link
Contributor

@spahrenk spahrenk commented Dec 10, 2024

Performance-map polynomials of recently added Bradford White and LG models were adjusted to prevent the use of unreasonable values within the ranges of allowed operating temperatures.
An additional 80-gal LG model has also been added.

@spahrenk spahrenk self-assigned this Dec 10, 2024
@spahrenk spahrenk requested a review from nealkruis December 10, 2024 18:20
Copy link
Member

@nealkruis nealkruis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spahrenk sorry--I missed the fact that the CI isn't happy here. Can you fix the formatting? We likely need to update the MacOS versions we are testing on too.

@spahrenk
Copy link
Contributor Author

Should be formatted now.

@nealkruis nealkruis changed the title Constrain perf curves; add 80-gal LG model Constrain performance curves and add 80-gallon LG model Dec 11, 2024
@nealkruis nealkruis merged commit ca59085 into main Dec 11, 2024
7 checks passed
@nealkruis nealkruis deleted the constrain-perf-curves-add-lg branch December 11, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants