fix(ci): apply gofmt -s across the tree#176
Merged
Merged
Conversation
CI's lint job runs `gofmt -s -l .` and fails when it returns anything; master is currently red because 15 files (mostly from the Tencent merge plus a few older spots in cmd/ask.go and internal/ai/client.go) need gofmt's simplifications applied. This commit is the mechanical result of `gofmt -s -w .` — pure struct-field-alignment whitespace, no logic changes. `go vet ./...` is clean and the api / maker tests still pass.
rephapeng
added a commit
to rephapeng/clanker
that referenced
this pull request
May 28, 2026
Upstream merged PR bgdnvk#165 (Tencent provider) and added work on top: k8s SRE playbooks (bgdnvk#174), SRE agent fix (bgdnvk#177), tree-wide gofmt -s (bgdnvk#176), README (bgdnvk#175), and three Tencent CLI features the fork lacked — `list --format json` (bgdnvk#179), `cost --format json` (bgdnvk#180), and security-scan CLI subcommands (bgdnvk#181). Conflict resolution: all 16 conflicts resolved to upstream's side. 14 were pure gofmt whitespace from bgdnvk#176 (identical code); billing.go and static_commands.go were upstream supersets adding the JSON/security CLI surface with no fork-unique code lost. Fixed a duplicate tencent import in cmd/ask.go left by the auto-merge. Verified in Docker (golang:1.25, -mod=mod): gofmt clean, go build ./..., go vet ./..., and go test ./... all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gofmt -s -l .reports 15 files needing simplification (mostly struct-field alignment).gofmt -s -w ., no logic changes.Files touched
cmd/ask.gointernal/ai/client.gointernal/api/{history,routes,routes_maker,routes_plan,server}.gointernal/tencent/{context,db_exposure,expiry,json_api,raw,security_scan,security_scan_p10,topology}.goVerification
gofmt -s -l .→ 0 filesgo vet ./...→ cleango test ./internal/api/ ./internal/maker/ -count=1→ pass