Skip to content

Set the owner permissions for config files #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Set the owner permissions for config files #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions manifests/config.pp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
file { $::grafana::cfg_location:
ensure => present,
content => template('grafana/config.ini.erb'),
owner => 'root',
group => 'grafana',
mode => '0440',
}
}
}
Expand All @@ -20,6 +23,9 @@
file { $::grafana::cfg_location:
ensure => present,
content => template('grafana/config.ini.erb'),
owner => 'root',
group => 'grafana',
mode => '0440',
}
}
'archive': {
Expand All @@ -28,6 +34,9 @@
file { "${::grafana::install_dir}/conf/custom.ini":
ensure => present,
content => template('grafana/config.ini.erb'),
owner => 'root',
group => 'grafana',
mode => '0440',
}
}
default: {
Expand All @@ -40,6 +49,9 @@
file { '/etc/grafana/ldap.toml':
ensure => present,
content => inline_template("<%= require 'toml'; TOML::Generator.new(@ldap_cfg).body %>\n"),
owner => 'root',
group => 'grafana',
mode => '0440',
}
}
}
14 changes: 14 additions & 0 deletions spec/classes/grafana_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,13 @@
describe 'should not contain any configuration when cfg param is empty' do
it { should contain_file('/etc/grafana/grafana.ini').with_content("# This file is managed by Puppet, any changes will be overwritten\n\n") }
end
describe 'should have the correct ownership and permissions for config file' do
it { should contain_file('/etc/grafana/grafana.ini').with(
:owner => 'root',
:group => 'grafana',
:mode => '0440',
)}
end

describe 'should correctly transform cfg param entries to Grafana configuration' do
let(:params) {{
Expand Down Expand Up @@ -303,6 +310,13 @@
"\n"

it { should contain_file('/etc/grafana/ldap.toml').with_content(ldap_expected) }
describe 'should have the correct ownership and permissions for ldap file' do
it { should contain_file('/etc/grafana/ldap.toml').with(
:owner => 'root',
:group => 'grafana',
:mode => '0440',
)}
end
end
end
end