Add support for favoriting maps #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcdrme
requested changes
Jan 30, 2025
| @@ -92,6 +100,13 @@ const imageUrl = computed(() => | |||
| } | |||
| transition: background-image 0.1s ease-in-out; | |||
| } | |||
| .favorite { | |||
There was a problem hiding this comment.
maybe add a backdrop / background of some sort to improve readability on light maps (snow maps especially)
There was a problem hiding this comment.
Added the same backdrop that is used for attributes to keep it consistent
bcdrme
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for being able to favorite maps and filter according to that.
Current Add/Remove button is placeholder as I will redo the whole Map details page once this is merged - as such it's purely functional.
I have toyed with the idea of having the heart on the map card be clickable as well, but decided against it because it would have to remain visible on hover while everything else fades away - can be done though if desired (to me it feels better UX-wise).
Resolves #250