Move skin code to a separate module#9899
Merged
mockersf merged 5 commits intobevyengine:mainfrom Sep 25, 2023
Merged
Conversation
mesh.rs is infamously large. We could split off unrelated code. Morph targets are very similar to skinning and have their own module. We move skinned meshes to an independent module like morph targets and give the systems similar names.
nicopap
added
A-Rendering
mockersf
reviewed
Sep 22, 2023
Co-authored-by: François <mockersf@gmail.com>
atlv24
approved these changes
Sep 23, 2023
Contributor
atlv24
left a comment
atlv24
left a comment
There was a problem hiding this comment.
These changes are good. I was hesitant at first with the skinned_mesh -> skins rename but i think it is less noisy and makes it easier to search for only mesh related stuff vs only skin related stuff in the codebase.
Co-authored-by: vero <email@atlasdostal.com>
mockersf
approved these changes
Sep 24, 2023
This replaces the comment added in 4339, detailing what exactly is special about our approach.
nicopap
force-pushed
the
skin-care-module
branch
from
41039bb to
7470a6d
Compare
mockersf
added
the
S-Ready-For-Final-Review
rdrpenguin04
pushed a commit
to rdrpenguin04/bevy
that referenced
this pull request
Jan 9, 2024
# Objective mesh.rs is infamously large. We could split off unrelated code. ## Solution Morph targets are very similar to skinning and have their own module. We move skinned meshes to an independent module like morph targets and give the systems similar names. ### Open questions Should the skinning systems and structs stay public? --- ## Migration Guide Renamed skinning systems, resources and components: - extract_skinned_meshes -> extract_skins - prepare_skinned_meshes -> prepare_skins - SkinnedMeshUniform -> SkinUniform - SkinnedMeshJoints -> SkinIndex --------- Co-authored-by: François <mockersf@gmail.com> Co-authored-by: vero <email@atlasdostal.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
mesh.rs is infamously large. We could split off unrelated code.
Solution
Morph targets are very similar to skinning and have their own module. We move skinned meshes to an independent module like morph targets and give the systems similar names.
Open questions
Should the skinning systems and structs stay public?
Migration Guide
Renamed skinning systems, resources and components: