Move ShaderCache shader defs into a resource #8202
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
NO_STORAGE_BUFFERS_SUPPORT
,NO_ARRAY_TEXTURES_SUPPORT
andSIXTEEN_BYTE_ALIGNMENT
are injected byShaderCache::get
, which occurs after pipeline specialization, and therefore afterMaterial
orMaterial2d
get the chance to inspect or mutate them in their respectivespecialize
functions.Fixes
Material::specialize
is provided an incomplete set of engine-sourced shader definitions #8190Solution
BaseShaderDefs
newtype resource, and have consuming pipelines retrieve it in theirFromWorld
implementation for use during specialization.Changelog
ShaderCache
BaseShaderDefs
resource implemented to hold affected defs, inserted into the render world byRenderPlugin
BaseShaderDefs
inFromWorld
, and use it in lieu of constructing an empty defs vec inspecialize
:Migration Guide
This is a non-breaking change, but future pipeline implementors should be made aware that the defs in question should be manually sourced from the ECS.