Skip to content

Replace unwraps with expects in bevy_window, bevy_scene and bevy_diagnostics #3975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

druskus20
Copy link

@druskus20 druskus20 commented Feb 18, 2022

Objective

Solution

@github-actions github-actions bot added the S-Needs-Triage This issue needs to be labelled label Feb 18, 2022
@alice-i-cecile
Copy link
Member

Thanks! This is a solid start, and definitely an improvement over the status quo. I left some comments; the type registry error needs some digging, and we should make the errors for missing resources more helpful.

@alice-i-cecile alice-i-cecile added A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Scenes Serialized ECS data stored on the disk A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use and removed S-Needs-Triage This issue needs to be labelled labels Feb 18, 2022
@alice-i-cecile
Copy link
Member

FYI, you can "Mark comment as resolved", which helps keep the PR tidy and easy to follow for reviewers :)

@ghost ghost mentioned this pull request Feb 18, 2022
31 tasks
@alice-i-cecile
Copy link
Member

Closing per discussion in #3899 <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Diagnostics Logging, crash handling, error reporting and performance analysis A-Scenes Serialized ECS data stored on the disk A-Windowing Platform-agnostic interface layer to run your app in C-Code-Quality A section of code that is hard to understand or change C-Usability A targeted quality-of-life change that makes Bevy easier to use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants