-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Replace unwraps with expects in bevy_window, bevy_scene and bevy_diagnostics #3975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! This is a solid start, and definitely an improvement over the status quo. I left some comments; the type registry error needs some digging, and we should make the errors for missing resources more helpful. |
FYI, you can "Mark comment as resolved", which helps keep the PR tidy and easy to follow for reviewers :) |
cart
reviewed
Feb 18, 2022
…TypeId>)" This reverts commit 8e77fbc.
alice-i-cecile
approved these changes
Feb 18, 2022
31 tasks
Closing per discussion in #3899 <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Diagnostics
Logging, crash handling, error reporting and performance analysis
A-Scenes
Serialized ECS data stored on the disk
A-Windowing
Platform-agnostic interface layer to run your app in
C-Code-Quality
A section of code that is hard to understand or change
C-Usability
A targeted quality-of-life change that makes Bevy easier to use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
unwrap
withexpect
#3899Solution
unwrap
withexpect
in some of the cratesturn ComponentDescriptor::type_id into a TypeId (from Option)