add calculate_tile_pos function #22456
Open
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
This adds a corresponding and opposite function to TilemapChunk::calculate_tile_transform. Similarly to that function, which ignores whether or not the given coordinates are outside of the chunk, returns the IVec2 of the coordinates the tile would have been at if such a tile existed, including returning negative values.
uwulasm
force-pushed
the
add_calculate_tile_pos
branch
from
90b907f to
002dbf6
Compare
| // divided by display size for a tile | ||
| / self.tile_display_size.x as f32 | ||
| // minus 3/2 to reverse the center correction | ||
| - 3. / 2. |
Contributor
There was a problem hiding this comment.
where did 3/2 come from?
Author
There was a problem hiding this comment.
it has to be done to prevent an off-by-one error
kfc35
added
A-Rendering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a corresponding and opposite function to TilemapChunk::calculate_tile_transform. Similarly to that function, which ignores whether or not the given coordinates are outside of the chunk, returns the IVec2 of the coordinates the tile would have been at if such a tile existed, including returning negative values.
Objective
There is currently an awkward asymmetry in the fact that the TilemapChunk allows converting from a tile position to a Transform, but does not allow converting from a general translation to a tile position. This seeks to fix this.
Solution
This adds the function TilemapChunk::calculate_tile_pos
Testing
Testing this function is simple. ideally, it should always do the opposite of the calculate_tile_transform function.