Skip to content

The fresnel can't hurt you any more #22454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cart merged 1 commit into from
Jan 9, 2026
Merged

The fresnel can't hurt you any more #22454

cart merged 1 commit into from
Jan 9, 2026
+3 −4

Conversation

@aevyrie
Copy link
Member

@aevyrie aevyrie commented Jan 9, 2026

image image

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22454

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@atlv24 atlv24 added M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered A-Rendering Drawing game state to the screen S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 9, 2026
@aevyrie
Copy link
Member Author

aevyrie commented Jan 9, 2026

I sure as hell hope it did.

@Zeophlite Zeophlite added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Jan 9, 2026
@JMS55
Copy link
Contributor

JMS55 commented Jan 9, 2026

Should we add a migration guide / release note?

@IceSentry
Copy link
Contributor

IceSentry commented Jan 9, 2026 •
edited
Loading

Release note yes, migration guide, not really. I'm not sure what's there to migrate for users.

@IceSentry IceSentry added the M-Release-Note Work that should be called out in the blog due to impact label Jan 9, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note.

Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes.

@cart cart added this pull request to the merge queue Jan 9, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 9, 2026
@cart cart added this pull request to the merge queue Jan 9, 2026
Merged via the queue into bevyengine:main with commit a9e8c55 Jan 9, 2026
49 checks passed
@github-project-automation github-project-automation bot moved this to Done in Rendering Jan 9, 2026
cart pushed a commit that referenced this pull request Jan 10, 2026
@aevyrie @cart
The fresnel can't hurt you any more (#22454)
f8e531d 
<img width="1224" height="792" alt="image"
src="https://github.com/user-attachments/assets/59e60ee4-e7ed-4a7b-8583-e0643dffac98"
/>
<img width="1224" height="792" alt="image"
src="https://github.com/user-attachments/assets/ee85f225-9f80-4c23-81bb-210b87dfcf32"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cart cart cart approved these changes

+3 more reviewers

@IceSentry IceSentry IceSentry approved these changes

@atlv24 atlv24 atlv24 approved these changes

@ecoskey ecoskey ecoskey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen M-Deliberate-Rendering-Change An intentional change to how tests and examples are rendered M-Release-Note Work that should be called out in the blog due to impact S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@aevyrie @JMS55 @IceSentry @cart @atlv24 @ecoskey @Zeophlite