reflect PartialOrd #22452
Open
reflect PartialOrd #22452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfc35
added
A-Reflection
kfc35
approved these changes
Jan 10, 2026
Contributor
There was a problem hiding this comment.
thank you for the tests 🙏 I don’t see anything obviously wrong with what is written as someone who is new to reading bevy reflect code. Seems to follow the patterns of the other traits appropriately.
(No structural comparsion following derive(PartialOrd) is implemented though).
I wonder if this is worth making an issue for implementing if we go forward with merging this
| /// A custom implementation may be provided using `#[reflect(PartialEq(my_partial_eq_func))]` where | ||
| /// `my_partial_eq_func` is the path to a function matching the signature: | ||
| /// `(&Self, value: &dyn #bevy_reflect_path::Reflect) -> bool`. | ||
| /// * `#[reflect(PartialOrd)]` will let the implementation of `PartialReflect::reflect_partial_cmp` |
Contributor
There was a problem hiding this comment.
If I’m understanding what you wrote correctly, and just to conform with what’s written for the other #[reflect(...)] comments:
Suggested change
| /// * `#[reflect(PartialOrd)]` will let the implementation of `PartialReflect::reflect_partial_cmp` | |
| /// * `#[reflect(PartialOrd)]` will force the implementation of `PartialReflect::reflect_partial_cmp` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
be able to compare ordering of two
dyn PartialReflectvaluesSolution.
add #[reflect(PartialOrd)] and method
PartialReflect::reflect_partial_cmp.(No structural comparsion following
derive(PartialOrd)is implemented though).Testing
Unit tests are added.