-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
TextPipeline::update_buffer collect Attrs directly
#22424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 9 commits into
bevyengine:main
from
ickshonpe:more-TextPipeline-cleanup
Jan 10, 2026
Merged
TextPipeline::update_buffer collect Attrs directly
#22424
alice-i-cecile
merged 9 commits into
bevyengine:main
from
ickshonpe:more-TextPipeline-cleanup
Jan 10, 2026
+31
−85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spans_buffer`, instead of mapping the collected text components from the spans buffer afterwards. Renamed `spans_buffer` to `sections_buffer`, span is potentially misleading as the root `Text`/`Text2d`'s text and attributes are also collected into this buffer, not just the `TextSpan`s. Removed the `FontFaceInfo` type as it is no longer used.
TextPipeline::update_buffer collect Attrs directly
alice-i-cecile
approved these changes
Jan 8, 2026
kristoff3r
approved these changes
Jan 9, 2026
kristoff3r
reviewed
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-Text
Rendering and layout for characters
C-Code-Quality
A section of code that is hard to understand or change
C-Performance
A change motivated by improving speed, memory usage or compile times
D-Straightforward
Simple bug fixes and API improvements, docs, test and examples
S-Ready-For-Final-Review
This PR has been approved by the community. It's ready for a maintainer to consider merging it
X-Uncontroversial
This work is generally agreed upon
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
We don't need to collect the text components into
TextPipeline's spans buffer, and then map them to Cosmic TextAttrslater. Instead we can create and collect theAttrsdirectly.Solution
Store the cosmic text
AttrsinTextPipeline::spans_buffer, instead of mapping the collected text components from the spans buffer afterwards.Rename
spans_buffertosections_buffer. "Span" is potentially misleading as the rootText/Text2d's text and attributes are also collected into this buffer, not just theTextSpans.Remove the
FontFaceInfotype, as it is no longer used.Testing
yellow = this PR, red = main 7a436e3