Generic font families #22396
Open
Generic font families #22396
+109
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, creating a new font with a new font ID to cosmic text's FontDb from the font asset each text update. This commit removes the responsibility of loading fonts to cosmic text's database and associating them with an asset id from `TextPipeline`. Instead the font family name is added to the `Font` asset after loading. Then in `TextPipeline::update_buffer` it just gets the family name from the asset and there's no possibility of a leak.
ickshonpe
added
S-Blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Add support for generic font families.
Solution
Support for generic font families has been added through new
FontSourcevariants:Serif,SansSerif,Cursive,Fantasy, andMonospace.The implementation is very simple, mostly just a mapping from the
FontSourcegeneric font family variants to the corresponding Cosmic TextFamilyvariants.Seems to work correctly, but the other text features follow up PRs should be merged first.
Showcase