TextPipeline::update_buffer return with early error on degenerate scale factor
#22392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor is <= 0 but if the scale factor is degenerate none of the text sections will be rendered. So perform the check separately at the start of the function and return with an early error if it fails.
ickshonpe
changed the title
TextPipeline::update_buffer return with early error on degenerate scale factor
ickshonpe
added
A-Text
kfc35
approved these changes
Jan 6, 2026
Contributor
kfc35
left a comment
kfc35
left a comment
There was a problem hiding this comment.
The example change seems unrelated, but that looks fine too so I’m approving it all
Contributor
Author
Didn't mean to include that, I must have based this on another PR by mistake. |
it-me-joda
approved these changes
Jan 6, 2026
ickshonpe
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
TextPipeline::update_bufferchecks per text section if the scale factor is <= 0 but if the scale factor is degenerate none of the text sections will be rendered. It would make more sense to perform the check once, at the start of the function, and return with an early error if it fails.Solution
Add a new variant to
TextErrorcalledDegenerateScaleFactor.At the start of the
update_bufferfunction, return with an earlyDegenerateScaleFactorerror if the scale factor is <= 0.