Minimal Font Families, Font Queries, Collections, System Fonts, Stretch, and Slant support by ickshonpe · Pull Request #22156 · bevyengine/bevy

ickshonpe · 2025-12-16T22:14:54Z

Objective

Implement support for the remaining missing text features with minimal changes.

Solution

TextFont has been expanded to include new fields:

pub struct TextFont {
    pub font: FontSource,
    pub font_size: f32,
    pub weight: FontWeight,
    pub width: FontWidth,
    pub style: FontStyle,
    pub font_smoothing: FontSmoothing,
    pub font_features: FontFeatures,
}

FontSource has two variants: Handle, which identifies a font by asset handle, and Family, which selects a font by its family name.

FontWidth is a newtype struct representing OpenType font stretch classifications ranging from ULTRA_CONDENSED (50%) to ULTRA_EXPANDED (200%).

FontStyle is an enum used to set the slant style of a font, either Normal, Italic, or Oblique.

The system font support is very barebones. You load them using the CosmicFontSystem resource:

font_system.db_mut().load_system_fonts()

Then they are available to be selected by family name using FontSource::Family.

Other changes

TextPipelines's glyph_info field has been removed. There is no need to collect the section infos or perform any querys during text layout updates, so that code has been removed as well.
update_text_layout_info used some try_for_each with some nested closures which was unnecessarily complicated again. They've been replaced with a regular for loop.
After font assets are loaded there's a new system load_font_assets_into_fontdb_system that automatically adds them to cosmic text's font database. Then they are available to be looked up by family name as well as by asset handle.
There aren't are performance motivated changes but layout updates seem to be overall significantly more efficient now, with a slight regression for very large numbers of short, single section text entities.
Font texture atlases are no longer automatically cleared when the font asset they were generated from is removed. There is no way to remove individual fonts from cosmic text's FontSystem, so the font is still accessible using the family name with FontSource::family and removing the text atlases naively could cause a panic since rendering expects them to be present.

Testing

cargo run --example font_query

Showcase

Added a `weight: Weight` field to `TextFont`.

`clamp` is called on `Weight` in the `From` impl for `cosmic_text::Weight`

…font-weight

Co-authored-by: Thierry Berger <contact@thierryberger.com>

github-actions · 2026-01-02T23:39:47Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22156

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

github-actions · 2026-01-02T23:46:26Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22156

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

github-actions · 2026-01-02T23:47:38Z

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-22156

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

…bevy into minimal-font-families

ickshonpe · 2026-01-03T01:46:06Z

@alice-i-cecile this should be more or less ready now. I'm too sleepy to wait and see if the CI passes though.

alice-i-cecile · 2026-01-03T03:04:01Z

CI is failing sadly :)

ickshonpe · 2026-01-03T12:17:25Z

CI is failing sadly :)

The markdown CI isn't giving any errors either, just failing. Maybe I've found the problem now.

ickshonpe · 2026-01-03T12:40:32Z

@alice-i-cecile ready now

# Objective Included some naive test code for system fonts in the `text` example in #22156 by mistake. ## Solution Revert the changes to the example.

# Objective #22156 introduced a leak 😓 . Every time a text section with a font handle font source is updated in `TextPipeLine::update_buffer`, a new font with a new font ID is added to cosmic text's FontDb. Fixes #22419 ## Solution Remove font loading and asset-ID association from TextPipeline. Instead, add the font family name to the `Font` asset after loading. Then `update_buffer` can just use the family name from the asset. ## Testing Add this system to the `text` example (or any bevy app with updating text): ```rust .add_systems(Update, |font_system: Res<CosmicFontSystem>| { println!("fonts: {}", font_system.db().len()); }) ``` You should observe the count increasing with every text update on main. The count should be stable with this PR.

ickshonpe and others added 30 commits December 5, 2025 09:38

* Added Weight type, a u16 wrapper identical to cosmic_text::Weight.

f5667c6

Added a `weight: Weight` field to `TextFont`.

Improved font weight docs

94a07dd

Cleanup

93e5f90

Improve docs and added clamp function to Weight.

7af1fc0

`clamp` is called on `Weight` in the `From` impl for `cosmic_text::Weight`

Add Weight to prelude

8ba4a4f

Added font_weights example.

5bfa0ae

Use the EbGaramond12-regular font in the font weights example.

2ebe0b3

Removed the weight field from FontFaceInfo.

0e964d5

Add debug + simpler example

81a2456

Clean up

265ba64

Added release note.

50fea97

clean up example

5c66154

Renamed font to pass CI

bd5b35b

Merge branch 'main' into font-weight

4b7a118

added ; for formatting

35baf7d

Merge branch 'font-weight' of https://github.com/ickshonpe/bevy into …

beaa291

…font-weight

Add PR number to release note

d16ddfe

Merge branch 'main' into font-weight

cb54d78

Merge branch 'main' into font-weight

7217021

Merge branch 'main' into font-weight

8e1cca5

Merge branch 'main' into font-weight

6218185

Merge branch 'main' into font-weight

c0ba51e

Fixed section info in update_text_layout_info.

3a44ae0

Collapsed double if let statements

a5ac340

Removed trailing space from release note

22b8d75

Merge branch 'main' into font-weight

cfa9a0f

Added link to online css font-weight documentation.

f467612

Merge branch 'font-weight' of https://github.com/ickshonpe/bevy into …

03aba63

…font-weight

Update crates/bevy_text/src/text.rs

9c3378c

Co-authored-by: Thierry Berger <contact@thierryberger.com>

Use MonaSans variable font instead of NotoSans

98e7db0

ickshonpe added 2 commits January 2, 2026 23:33

Removed unneeded lifetime from update_text_layout_info

8c98d27

Removed unnecessary cast

420b0d3

Merge branch 'main' into minimal-font-families

716ce8f

ickshonpe added 5 commits January 3, 2026 00:12

Make initial section start and end at same point

fbcdcc0

Merge branch 'minimal-font-families' of https://github.com/ickshonpe/…

2f871c6

…bevy into minimal-font-families

updated dynamic_mip_generation example

4369da9

Added migration amd release content.

1b36f62

Fixed spelling mistake

4fe04ad

ickshonpe mentioned this pull request Jan 3, 2026

Replace the section info septuple in bevy_text::pipeline with a struct #22352

Closed

Fix release content

fb1b400

ickshonpe added 3 commits January 3, 2026 10:48

Fix examples

dcaa0bc

Fixed another example

5b48a75

Updated release content again.

4d3da26

ickshonpe added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jan 3, 2026

alice-i-cecile added this pull request to the merge queue Jan 3, 2026

Merged via the queue into bevyengine:main with commit e5d4dfd Jan 3, 2026
44 checks passed

This was referenced Jan 5, 2026

Fix font ID leak in TextPipeline #22386

Merged

Remove system fonts test code from the text example. #22390

Merged

ickshonpe mentioned this pull request Jan 7, 2026

Font ID leak #22419

Closed

Navigation Menu

Uh oh!

Minimal Font Families, Font Queries, Collections, System Fonts, Stretch, and Slant support - #22156

Minimal Font Families, Font Queries, Collections, System Fonts, Stretch, and Slant support#22156
alice-i-cecile merged 90 commits into
bevyengine:mainfrom
ickshonpe:minimal-font-families

ickshonpe commented Dec 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

ickshonpe commented Jan 3, 2026

Uh oh!

alice-i-cecile commented Jan 3, 2026

Uh oh!

ickshonpe commented Jan 3, 2026 •

edited

Loading

Uh oh!

ickshonpe commented Jan 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

ickshonpe commented Dec 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Other changes

Testing

Showcase

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

github-actions Bot commented Jan 2, 2026

Uh oh!

ickshonpe commented Jan 3, 2026

Uh oh!

alice-i-cecile commented Jan 3, 2026

Uh oh!

ickshonpe commented Jan 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ickshonpe commented Jan 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ickshonpe commented Dec 16, 2025 •

edited

Loading

ickshonpe commented Jan 3, 2026 •

edited

Loading