Switch to try_insert in UICameraPropagate #21519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cBournhonesque
added
C-Bug
villor
approved these changes
Oct 12, 2025
alice-i-cecile
approved these changes
Oct 12, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective I've been having panics in situations where: - I despawn a UI Root Node in PostUpdate - I don't have any system order dependency between my PostUpdate system and `UiSystems::Prepare`, so there was no sync point between the two Therefore the order of operations was: - My system runs and queues a command to despawn a root node - The UI system runs and tries to insert `Propagate` on my root node - CommandExecutions: - my command to despawn the root node is executed - the command to insert Propagate is executed, causing a panics This means that any attempt to despawn a Root node in PostUpdate will probably cause these kinds of panics. ## Solution Replace the command with `try_insert` so that if the Root Node is despawned we don't try to add a Propagate component on it. ## Testing This fixed the issue in my repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
I've been having panics in situations where:
UiSystems::Prepare, so there was no sync point between the twoTherefore the order of operations was:
Propagateon my root nodeThis means that any attempt to despawn a Root node in PostUpdate will probably cause these kinds of panics.
Solution
Replace the command with
try_insertso that if the Root Node is despawned we don't try to add a Propagate component on it.Testing
This fixed the issue in my repo