Load ktx2 LUT images with sRGB off. #21432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andriyDev
added
C-Bug
tychedelia
approved these changes
Oct 7, 2025
andriyDev
added
S-Ready-For-Final-Review
ChristopherBiscardi
approved these changes
Oct 7, 2025
tigregalis
pushed a commit
to tigregalis/bevy
that referenced
this pull request
Oct 7, 2025
# Objective - Fixes bevyengine#21425. - Prior to bevyengine#19408, we were loading the LUTs with sRGB off. bevyengine#19408 accidentally did not maintain this behavior. ## Solution - Specify the settings for the LUTs to disable sRGB. - Also make the LUTs only accessible in the render world. ## Testing - Ran the anti_aliasing example. Compared no AA to SMAA and it looks different now!
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective - Fixes bevyengine#21425. - Prior to bevyengine#19408, we were loading the LUTs with sRGB off. bevyengine#19408 accidentally did not maintain this behavior. ## Solution - Specify the settings for the LUTs to disable sRGB. - Also make the LUTs only accessible in the render world. ## Testing - Ran the anti_aliasing example. Compared no AA to SMAA and it looks different now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
weak_handle. #19408, we were loading the LUTs with sRGB off. Clean up several miscellaneous uses ofweak_handle. #19408 accidentally did not maintain this behavior.Solution
Testing