fix: query UiGlobalTransform instead of GlobalTransform
#21382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
approved these changes
Oct 4, 2025
alice-i-cecile
added
C-Bug
alice-i-cecile
added
X-Uncontroversial
|
Hey @chompaa want to give us a quick review here? |
|
Oh yeah I remember checking this example and noticing interactions through the viewport node weren't recognised, but I didn't realise it was broken, I just completely forgot and thought we must have never implemented them 😅 |
chompaa
approved these changes
Oct 4, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Oct 6, 2025
…ne#21382) # Objective Fixes bevyengine#21381 ## Solution - Describe the solution used to achieve the objective above. ## Testing - I tested the changes on examples/ui/viewport_node --------- Co-authored-by: 0xfff <[email protected]>
tigregalis
pushed a commit
to tigregalis/bevy
that referenced
this pull request
Oct 7, 2025
…ne#21382) # Objective Fixes bevyengine#21381 ## Solution - Describe the solution used to achieve the objective above. ## Testing - I tested the changes on examples/ui/viewport_node --------- Co-authored-by: 0xfff <[email protected]>
mastamitche
pushed a commit
to mastamitche/bevy
that referenced
this pull request
Oct 11, 2025
…ne#21382) # Objective Fixes bevyengine#21381 ## Solution - Describe the solution used to achieve the objective above. ## Testing - I tested the changes on examples/ui/viewport_node --------- Co-authored-by: 0xfff <[email protected]>
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
…ne#21382) # Objective Fixes bevyengine#21381 ## Solution - Describe the solution used to achieve the objective above. ## Testing - I tested the changes on examples/ui/viewport_node --------- Co-authored-by: 0xfff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #21381
Solution
Testing