Relax deferred UnsafeWorldCell visibility #21360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CorvusPrudens
added
S-Needs-Review
chescock
approved these changes
Oct 3, 2025
Shatur
approved these changes
Oct 4, 2025
There was a problem hiding this comment.
This is neat, I'll be able to avoid this re-borrow in bevy_replicon.
alice-i-cecile
added
S-Ready-For-Final-Review
beicause
pushed a commit
to beicause/bevy
that referenced
this pull request
Oct 6, 2025
# Objective Addresses the immediate blocker in bevyengine#21354 by relaxing the `(crate)` visibility restriction on `DeferredWorld::as_unsafe_world_cell`. This method already has documentation, including a safety comment. While sparse, I think they communicate the function clearly.
tigregalis
pushed a commit
to tigregalis/bevy
that referenced
this pull request
Oct 7, 2025
# Objective Addresses the immediate blocker in bevyengine#21354 by relaxing the `(crate)` visibility restriction on `DeferredWorld::as_unsafe_world_cell`. This method already has documentation, including a safety comment. While sparse, I think they communicate the function clearly.
|
Awesome, I was just about to open a PR for this, I needed this :) |
mate-h
pushed a commit
to mate-h/bevy
that referenced
this pull request
Oct 22, 2025
# Objective Addresses the immediate blocker in bevyengine#21354 by relaxing the `(crate)` visibility restriction on `DeferredWorld::as_unsafe_world_cell`. This method already has documentation, including a safety comment. While sparse, I think they communicate the function clearly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Addresses the immediate blocker in #21354 by relaxing the
(crate)visibility restriction onDeferredWorld::as_unsafe_world_cell.This method already has documentation, including a safety comment. While sparse, I think they communicate the function clearly.