Skip to content

Conversation

@WaterWhisperer
Copy link
Contributor

Objective

Fixes #17314

Solution

Enable the track_location feature for bevy_ecs tests (but not benchmarks)

Testing

I verified it by running the cargo test command before and after the modification locally

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile
Copy link
Member

Related to #21364

Copy link
Contributor

@janis-bhm janis-bhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like having this would have caught #21293 earlier!

Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing tests, or disable them to be addressed in a follow-up PR.

@janis-bhm
Copy link
Contributor

Please fix the failing tests, or disable them to be addressed in a follow-up PR.

#21364 fixes this test failure btw. I should have mentioned that in my comment.

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events A-Build-System Related to build systems or continuous integration S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Oct 3, 2025
@alice-i-cecile
Copy link
Member

Adopted in #21364. Thank you @WaterWhisperer; we'll merge this in as part of that work.

@WaterWhisperer WaterWhisperer deleted the enable-track_location branch October 4, 2025 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Build-System Related to build systems or continuous integration A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable track_location tests

4 participants