-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add optional transparency passthrough for sprite backend with bevy_picking #16388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
alice-i-cecile
merged 38 commits into
bevyengine:main
from
vandie:ignore_transparancy_on_sprite_picking
Dec 5, 2024
Merged
Changes from all commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
c5dd17a
Add optional transparancy passthrough for sprite backend
vandie bba576b
set correct default
vandie f9088c7
fix typo
vandie d1013cf
fix too many arguments
vandie 1924e02
fix doc typo
vandie 42c156b
clean up final check into match
vandie 3ca1039
fix docs and naming
vandie 7038101
change transparency to alpha in variable names
vandie 1f48ff2
Add AlphaPassthrough enum and change default to on
vandie 5ee1448
improve comments
vandie 16f8654
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 38eb823
update comments
vandie 26f4511
update comments
vandie 0737631
rename Sprite Picking Mode
vandie 0acb495
fix typo
vandie e35c25d
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 71f9383
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 3afc5ca
switch to using bevy internal `get_color_at`
vandie f0a9095
add missing backticks
vandie c9fff89
fix double backticks
vandie c246fba
improve accuracy and stop out of range error
vandie 513a934
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie c64dbdf
change floor location
vandie 50e862d
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 323f08d
Merge branch 'main' into HEAD
andriyDev 54bdc5f
Create `compute_pixel_space_point` to convert from a point relative t…
andriyDev 6b5a176
Rewrite the sprite picking backend to use `Sprite::compute_pixel_spac…
andriyDev 23cc626
Add a comment to clarify that we know the cursor is in the bounds of …
andriyDev f46f67c
Make the sprite_picking system private, but then re-export everything…
andriyDev e3d6736
Remove flipping the y-value of the cursor from the picking backend.
andriyDev f3476e0
Rename `SpriteBackendSettings` to `SpritePickingSettings`.
andriyDev 8eb09ff
Move all the pixel computations to `Sprite::compute_pixel_space_point`.
vandie db392ab
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie eca8e10
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 22e7547
remove un-needed closure
vandie 64f1cf7
fix comments
vandie 7ed99c5
Merge branch 'main' into ignore_transparancy_on_sprite_picking
vandie 8bff88a
added @andriyDev's comment to code
vandie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.