-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Arc-d assets #15813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
andriyDev
wants to merge
31
commits into
bevyengine:main
Choose a base branch
from
andriyDev:arc-assets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+579
−142
Open
Arc-d assets #15813
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
855753b
Remove all the `get_mut` functions from `Assets`.
andriyDev 2263910
Make `Assets` store assets as `Arc<A>` instead of just `A`.
andriyDev 68efabd
Separate out inserting/adding an owned asset from the arc version.
andriyDev d293199
Implement `get_cloned_mut`.
andriyDev b93a63d
Implement `get_inplace_mut`.
andriyDev 8818bbb
Implement `get_reflect_cloned_mut`.
andriyDev d4b20c1
Update most calls in bevy_asset to either use a `.into()` or one of t…
andriyDev f4a1e27
Make RenderAssets take an `Arc` to the source asset and extract sourc…
andriyDev 1480923
Make all the crates use the new `get_*_mut` variants, or use `Arc<Sou…
andriyDev 901d843
Update the examples to use the `get_*_mut` variants or otherwise deal…
andriyDev 603ea1b
Create an example for the use of asset arcing.
andriyDev 4822dbc
Add a nice big warning on `get_arc` about holding the `Arc` for long …
andriyDev a9341f3
Rewrite any "Arc-ed" to "Arc-d" to make it consistent with other uses.
andriyDev add3c66
Improve the MutableAssetError messages to match Rust guidelines.
andriyDev f6a6505
Rename `get_inplace_mut` to `get_in_place_mut`.
andriyDev d13ca5f
Fix the example using bad wording.
andriyDev 88098ce
Switch MutableAssetError to use thiserror instead of derive_more.
andriyDev e794441
Fix the `asset_changed` test by using `get_inplace_mut`.
andriyDev 3dc1a8e
Make the docs for `AssetChanged` reference `get_cloned_mut` instead o…
andriyDev f02d558
Fix the `mixed_lighting` example to use `get_cloned_mut`.
andriyDev 07931ad
Fix the `many_materials` and `edit_material_on_gltf` examples.
andriyDev 7eca4aa
Fix the `specular_tint` example.
andriyDev 9d4a394
Merge branch 'main' into arc-assets
mockersf bda9f50
Replace `gen` with `r#gen` to transition to edition 2024.
andriyDev b8a3e1f
Fix the many_cubes stress test to use Arc::make_mut for the materials.
andriyDev 724cb25
Merge branch 'main' into arc-assets
andriyDev b332f7b
Rename `heights.li.ron` to `arc_asset_heights.li.ron`.
andriyDev 338aa26
Rename `arc_asset` example to `access_asset_from_async`.
andriyDev da9f2a9
Merge branch 'main' into arc-assets
andriyDev 97b97b5
Merge branch 'main' into arc-assets
andriyDev a970124
Fix up a handful of cases not covered by the merge.
andriyDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the focus of the example should not be "arc_asset", it should be "async_access_to_asset" or something. arc is the technical detail, not the interesting feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Done.