-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
bevy_reflect: Add ReflectSerializerProcessor
#15548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 39 commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
9d59375
Add ReflectDeserializerProcessor
aecsocket 8f5cd7b
fix clippy
aecsocket 6749256
improve docs
aecsocket 38e618f
address comments
aecsocket c8a3980
ReflectDeserializerProcessor `should_deserialize` returns the actual …
aecsocket 5e6d02c
wip: switch to type param for reflect deserializer processor
aecsocket 19bd7d8
fix processor
aecsocket 56dbf02
get it working with the type system
aecsocket 4a4993e
fix docs for deserialize processor
aecsocket 2c983cc
fix doc tests
aecsocket 1d5f725
Add default `P = ()` for ReflectDeserializer
aecsocket 283bc15
add P = () to TypedReflectDeserializer as well
aecsocket 4a4ddaf
Use `new_internal` in reflect deserializer
aecsocket 7b534db
Provide access to TypeRegistry from processor
aecsocket 06e1a65
doc fix
aecsocket 428bfa2
fix doc tests
aecsocket c9168b6
Update for main
aecsocket bb1bc39
Address review comments
aecsocket fa1f55a
more docs and test for returning Box of wrong type
aecsocket e689f6b
clippy
aecsocket 066d722
fix docs
aecsocket 63dae42
wip: image pipeline example
aecsocket 56c7e17
working logic
aecsocket e76e63d
Update examples/README.md
aecsocket 18069a9
Add nicer image asset for image processor example
aecsocket 9e447be
fix up rebase
aecsocket 27a3183
further fix up rebase
aecsocket b00d98d
remove `as_ref`s
aecsocket 7a652af
add more processor docs
aecsocket aa0d89b
remove example
aecsocket 7faf965
switch to incorrect spelling
aecsocket b9eecfc
Add ReflectSerializerProcessor
aecsocket e55a4c7
fix up rebase
aecsocket a70451d
switch to incorrect spelling
aecsocket d265b9b
Add docs
aecsocket fba8187
Merge branch 'main' into feat/reflect-ser
aecsocket 631d22e
Address review comments
aecsocket 41384c9
replace `map(Ok)` with `Ok(Ok(..))` wrapping
aecsocket d99ca7c
fix doc
aecsocket 3078fcd
doc cleanup
aecsocket dce23e6
fix doc
aecsocket File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we move this up to above
# Compared to ...and remove the section header like you did forReflectSerializerProcessor?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did that change already, but didn't save the file 🤦 Fixed and pushed.