Skip to content

Ignore PipelineCache ambiguities #14772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2024
Merged

Ignore PipelineCache ambiguities #14772

merged 3 commits into from
Aug 16, 2024

Conversation

alice-i-cecile
Copy link
Member

Objective

The prepare_view_upscaling_pipelines system has dozens of ambiguities, which makes it harder to spot and prevent new ambiguities.

Closes #14770.

Solution

Just exclude the system from ambiguity detection. See the linked issue for more context on why this resolution was chosen.

Testing

Running the ambiguity_detection example now reports dozens fewer Render app ambiguities.

@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy A-Rendering Drawing game state to the screen C-Usability A targeted quality-of-life change that makes Bevy easier to use C-Testing A change that impacts how we test Bevy or how users test their apps X-Contentious There are nontrivial implications that should be thought through S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 16, 2024
@alice-i-cecile alice-i-cecile requested a review from JMS55 August 16, 2024 00:50
@alice-i-cecile
Copy link
Member Author

I've left my first WIP commit in the history here so reviewers can see what an alternate explicit ordering solution would look like. That was about a quarter of the required changes, all of which worked the same way.

tychedelia
tychedelia approved these changes Aug 16, 2024
View reviewed changes
Copy link
Member

@tychedelia tychedelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. It's okay to be a lil lazy sometimes. :)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 16, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 16, 2024
Merged via the queue into bevyengine:main with commit da529ff Aug 16, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tychedelia tychedelia tychedelia approved these changes

@JMS55 JMS55 JMS55 approved these changes

@cart cart Awaiting requested review from cart

@IceSentry IceSentry Awaiting requested review from IceSentry

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Testing A change that impacts how we test Bevy or how users test their apps C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Contentious There are nontrivial implications that should be thought through
Projects
Rendering
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prepare_view_upscaling_pipelines is ambiguous with dozens of other systems
3 participants
@alice-i-cecile @tychedelia @JMS55