Improve ambiguity detection example / test #14760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
A-ECS
alice-i-cecile
commented
Aug 15, 2024
benfrankel
reviewed
Aug 15, 2024
… set" This reverts commit 6180657.
benfrankel
approved these changes
Aug 15, 2024
alice-i-cecile
added
the
S-Needs-Review
chescock
approved these changes
Aug 15, 2024
janhohenheim
added
S-Ready-For-Final-Review
janhohenheim
approved these changes
Aug 15, 2024
| @@ -1,32 +1,17 @@ | |||
| //! A test to confirm that `bevy` doesn't regress its system ambiguities count when using [`DefaultPlugins`]. | |||
| //! This is run in CI. | |||
| //! | |||
| //! Note that because this test requires rendering, it isn't actually an integration test! | |||
| //! Instead, it's secretly an example: you can run this test manually using `cargo run --example ambiguity_detection`. | |||
Co-authored-by: Jan Hohenheim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
While tackling #7386, I noticed a few nits / frustrations with the existing testing infrastructure.
Rather than mixing those changes in with much more challenging to review changes to reduce ambiguities, I've split this work into its own PR.
Solution
Substantially simplify the
ambiguity_detectiontest code, and reduce the verbosity of logging.Testing
When run locally, the test functions as expected, with somewhat cleaner logging.