run windows ci on rust 1.78 #13834
Merged
run windows ci on rust 1.78 #13834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockersf
added
the
A-Build-System
alice-i-cecile
approved these changes
Jun 13, 2024
|
Reported upstream at rust-lang/rust#126442 |
mnmaita
approved these changes
Jun 14, 2024
alice-i-cecile
added
the
S-Waiting-on-Author
|
A fix and backport seems imminent: I'll defer to @mockersf about whether we should merge or close this. |
|
let's merge this now to be able to continue merging PRs on Bevy while waiting for the patch |
|
Which would be the WGPU fix that lets us revert this change @mockersf, do you know this? Asking so I can track it and get it done. |
|
Once there's a wgpu release with gfx-rs/wgpu#5812 in it we can revert this. |
|
#13863 to merge after that release |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
- Revert #13834 once wgpu released the fix for gfx-rs/wgpu#5812
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
- Revert bevyengine#13834 once wgpu released the fix for gfx-rs/wgpu#5812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution