Unrevert (vert?) "Add on_unimplemented Diagnostics to Most Public Traits"
#13414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 17, 2024 08:51
…yengine#13347)" This reverts commit 11f0a2d.
…its (bevyengine#13347)"" This reverts commit c93312b.
alice-i-cecile
added
S-Blocked
Merged
alice-i-cecile
added
the
S-Ready-For-Final-Review
alice-i-cecile
removed
the
S-Blocked
|
Unfortunately still blocked because #13366 failed the merge queue. :( |
|
Unblocked |
BD103
approved these changes
Jun 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
…3662) # Objective - #13414 did not have the intended effect. - #13404 is still blocked ## Solution - Re-adds #13347. Co-authored-by: Zachary Harrold <[email protected]> Co-authored-by: Jamie Ridding <[email protected]> Co-authored-by: BD103 <[email protected]>
knutsoned
pushed a commit
to knutsoned/bevy
that referenced
this pull request
Jun 25, 2024
…raits" (bevyengine#13414) # Objective - bevyengine#13347 was good actually ## Solution - Add it back to main (once bevyengine#13366 is merged) --------- Co-authored-by: Alice Cecile <[email protected]>
patrickariel
pushed a commit
to patrickariel/bevy
that referenced
this pull request
Sep 11, 2024
…raits" (bevyengine#13414) # Objective - bevyengine#13347 was good actually ## Solution - Add it back to main (once bevyengine#13366 is merged) --------- Co-authored-by: Alice Cecile <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
on_unimplementedDiagnostics to Most Public Traits #13347 was good actuallySolution